search

SerpentDrago / skin.auramod

Auramod Skin for Kodi 18
85 stars 20 forks source link

[Bug] Search Results are not in the default veiw when you hover over them. #6

Closed Goldenfreddy0703 closed 3 years ago

Goldenfreddy0703 commented 3 years ago

Describe the bug I don't really think this is a bug but when i search for something, Every poster that i hover to goes to landscape view and i looked in the skin settings but i could not find the fix for it.

To Reproduce Steps to reproduce the behavior:

  1. Go to settings and go to Search list.
  2. In Search list find an addon that you would like to add to your search.
  3. Try searching something in the search bar and get result
  4. Hover over the posters and see the error that they are in landscape view.

Expected behavior See the search results in poster view.

Screenshots Veiw

Desktop (please complete the following information):

Additional context I don't know why they are in landscape view but i hope this is an error or bug and hope this can be fixed in the future.

SerpentDrago commented 3 years ago

Edit your search lists and Change the "widget style " and any other option for that search widget to what you would like , just like any other widget

image

Goldenfreddy0703 commented 3 years ago

ok so i did try that but when you hover over that poster it changes to landscape mode. kodi 18 auramod Here is what it was originally when we were on Kodi 18 back then. Veiw Kodi 19 Auramod search result looks different.

Goldenfreddy0703 commented 3 years ago

[edit] Im really sorry i should have shown you this image with multiple results, not one. Kodi 19 This is what i mean.

SerpentDrago commented 3 years ago

seems its not just making them landscape on Focus , its also making them massive ..

I have no idea whats going on , yes just tested it i'm getting same behavior ... hummmm

SerpentDrago commented 3 years ago

For now you can switch it to Poster Details .. at at least will keep the poster artwork (with other stuff )

I have 0 idea whats causing this wacky bug , and its causing some widget types to not even work at all . and causing shit to be massively zoomed in

Have you noticed anything like this in any other part of the skin ? or just search results (again i dont' actively use kodi much anymore )

Goldenfreddy0703 commented 3 years ago

Mostly just in search results and that's about it

SerpentDrago commented 3 years ago

Mostly ?

xyzfre commented 3 years ago

For now you can switch it to Poster Details .. at at least will keep the poster artwork (with other stuff )

I have 0 idea whats causing this wacky bug , and its causing some widget types to not even work at all . and causing shit to be massively zoomed in

Have you noticed anything like this in any other part of the skin ? or just search results (again i dont' actively use kodi much anymore )

My apologies for commenting on this issue but it has to do with widgets if you use on the home screen widgets landscape view with showcase overlay enabled when scrolling the fix focus doesn’t work and when you scroll to the end you cannot see The See More

xyzfre commented 3 years ago

And lots of respect for your work bro AuraMod is the best skin I have ever tried been using it for 2years really appreciate you looking into these small bugs

xyzfre commented 3 years ago

that’s using Home Layout Style,,Aura Home Layout with vertical icons

Goldenfreddy0703 commented 3 years ago

sorry this happens in the search results for me and thats about it

SerpentDrago commented 3 years ago

For now you can switch it to Poster Details .. at at least will keep the poster artwork (with other stuff ) I have 0 idea whats causing this wacky bug , and its causing some widget types to not even work at all . and causing shit to be massively zoomed in Have you noticed anything like this in any other part of the skin ? or just search results (again i dont' actively use kodi much anymore )

My apologies for commenting on this issue but it has to do with widgets if you use on the home screen widgets landscape view with showcase overlay enabled when scrolling the fix focus doesn’t work and when you scroll to the end you cannot see The See More

This is a completely different bug , i'm aware of but need someone to post a DETAILED issue for if it is only a matrix 19 bug . (Fixed focus bug ) Please be detailed and i'll add it to a todo if there is a issue posted

The issue that happening here in this thread is related to the Search Results ONLY , and has nothing to do with fixed focus and normal widgets

SerpentDrago commented 3 years ago

@xyzfre Could you make a Issue post , descriptive , with the fixed widget / non fixed widget bug issue your having . that way i have it on record as something to look into .. eventually lol .

Dealz-416LS commented 3 years ago

Mostly ?

Also happening in Hubs and My Lists.

Poster is set for widgets but switches to Landscape on focus.

SerpentDrago commented 3 years ago

Mostly ?

Also happening in Hubs and My Lists.

Poster is set for widgets but switches to Landscape on focus.

ohh just fucking great !

This is going to be a tough one guys. I'll put it at the top of the list

Dealz-416LS commented 3 years ago

Sorry to be the bearer of more bad news but i have additional details as i didn't see it mentioned.

Doesn't just happen to Poster style.

SqaureLabel is set for widget (tmdb people) but the first item is landscape and also switches to landscape on focus.

Kodi_20210321_230519

Despite the small bugs here and there overall I think this is the best skin I've ever used! I appreciate the time and effort you put into it!

SerpentDrago commented 3 years ago

Yeh i'm aware , same bug it pritty much effects most any widget style .

i'll have to call in help to fix this , once i at least narrow down where all the stuff is for it ..

Again . if i get the motivation to work on it .

inb4after commented 3 years ago

Tested each widgetAspect and some attempted fixes, but the issue seems to be with overlapping conditional statements rather than the widgetAspect itself. I've compiled a list of the working stuff and the bugs, which might help those who can take a closer look at the widgetAspect stuff. But at the moment it looks like a rewrite is needed as I can't find any obvious cause (I'm not very good at skins!)

Search:

Widgets:

SerpentDrago commented 3 years ago

Fantastic research man ! , did you test on a normal home screen widget or from a hub / my list / search hub ??

reports i've gotten seem to indicate it only happens on hubs / my lists and not on the home screen direct from a menu section widgets

inb4after commented 3 years ago

Fantastic research man ! , did you test on a normal home screen widget or from a hub / my list / search hub ??

reports i've gotten seem to indicate it only happens on hubs / my lists and not on the home screen direct from a menu section widgets

It did happen on a normal homescreen widget. I haven't tested hubs or my lists. Maybe have an idea why it could be like this, need to test more and I'll get back to you.

I am testing using Netflix Home Layout, which could be different to other layouts. Perhaps some widgetAspect are supposed to be disabled using this home layout, but the skin shows them anyway? That would make more sense for the Widget bugs.

I also think some bugs are carried from Leia as well. This may be one of them, I will double check on there as well, but Search widgetAspect was definitely working on Leia, for Landscape at least.

BTW check Discord whenever you're available, I am more active over there.

SerpentDrago commented 3 years ago

Roger will do

Goldenfreddy0703 commented 3 years ago

Hey @inb4after ,sorry for bothering you but i just wanted to say that you did fantastic research on the View menu, Search fields, and the Widgets. Im really impressed that you got all these working. If its ok, do you think you can take a look at Arctic Horizon Skin thats from jurialmunkey? I think people needed help on some of the views layouts and widgets and getting it converted to python 3 and i think you would be the right person to ask.

https://github.com/jurialmunkey/skin.arctic.horizon

SerpentDrago commented 3 years ago

Hey @inb4after ,sorry for bothering you but i just wanted to say that you did fantastic research on the View menu, Search fields, and the Widgets. Im really impressed that you got all these working. If its ok, do you think you can take a look at Arctic Horizon Skin thats from jurialmunkey? I think people needed help on some of the views layouts and widgets and getting it converted to python 3 and i think you would be the right person to ask.

https://github.com/jurialmunkey/skin.arctic.horizon

Jurial is already a expert in skinning and his skin , I highly doubt he needs any help . if theres a issue with AH , Jurial will fix it . he even has a official matrix version and a matrix repo .