SerpentDrago / skin.auramod

Auramod Skin for Kodi 18
85 stars 20 forks source link

Cast & More > Cast > Custom actor window: Unable to press down to view extra widgets #92

Open inb4after opened 3 years ago

inb4after commented 3 years ago

Video of bug: https://imgur.com/a/1gzhwxW Video of how it should be: http://imgur.com/a/VTlLEev

Videos courtesy of @adamosborne83

After the custom actor window loads, they are unable to press down to view the extra widgets.

This strange issue only affects some users and seems to be inconsistent. I've tested on my Shield and do not get this bug, however it does mainly affect android devices including another's Shield.

It could be that these devices are slower than PC's but it is more likely to be a setting that is affecting the outcome.

inb4after commented 3 years ago

@adamosborne83 @Dealz-416LS @xyzfre

Please test the Testing-ActorHotFix branch to see if it resolves this issue as I cannot reproduce it.

adamosborne83 commented 3 years ago

@adamosborne83 @Dealz-416LS @xyzfre

Please test the Testing-ActorHotFix branch to see if it resolves this issue as I cannot reproduce it.

Cheers for acting so quick, bloody amazing.

I will test it later after work.

Cheers as always

inb4after commented 3 years ago

@adamosborne83 @Dealz-416LS @xyzfre Please test the Testing-ActorHotFix branch to see if it resolves this issue as I cannot reproduce it.

Cheers for acting so quick, bloody amazing.

I will test it later after work.

Cheers as always

It's more of trial and error fixes, hoping to find the actual cause randomly as it's difficult to diagnose.

xyzfre commented 3 years ago

@adamosborne83 @Dealz-416LS @xyzfre

Please test the Testing-ActorHotFix branch to see if it resolves this issue as I

@adamosborne83 @Dealz-416LS @xyzfre

Please test the Testing-ActorHotFix branch to see if it resolves this issue as I cannot reproduce it.

Definitely going to apply this branch to see if it fixes the issue will keep you posted for sure ,,thank you for all the hard work you guys are putting into AuraMod it is the best skin out there I consider it a legend✊🏼

inb4after commented 3 years ago

@adamosborne83 @Dealz-416LS @xyzfre

Please test the Testing-ActorHotFix branch to see if it resolves this issue as I

@adamosborne83 @Dealz-416LS @xyzfre

Please test the Testing-ActorHotFix branch to see if it resolves this issue as I cannot reproduce it.

Definitely going to apply this branch to see if it fixes the issue will keep you posted for sure ,,thank you for all the hard work you guys are putting into AuraMod it is the best skin out there I consider it a legend✊🏼

Another user has said this fix didn't work.

I'm now thinking it's a skin setting or Kodi setting that is different in our setups and is causing this bug only for some users.

xyzfre commented 3 years ago

@adamosborne83 @Dealz-416LS @xyzfre Please test the Testing-ActorHotFix branch to see if it resolves this issue as I

@adamosborne83 @Dealz-416LS @xyzfre Please test the Testing-ActorHotFix branch to see if it resolves this issue as I cannot reproduce it.

Definitely going to apply this branch to see if it fixes the issue will keep you posted for sure ,,thank you for all the hard work you guys are putting into AuraMod it is the best skin out there I consider it a legend✊🏼

Another user has said this fix didn't work.

I'm now thinking it's a skin setting or Kodi setting that is different in our setups and is causing this bug only for some users.

Should I still give this branch a try ,, and if you need me to test some settings that you might want me to enable or disable just keep me posted I’m always willing to help,, but I recall even on 18.9 I remember this happening As well when pushing down nothing would happen I’m using a Nvidia Shield pro

adamosborne83 commented 3 years ago

Hey, nope didn't work. Cheers for trying.

No logs to add as its got no errors or anything, and if it is a setting, then no chance of figuring it out haha

xyzfre commented 3 years ago

https://user-images.githubusercontent.com/49699869/118303704-c019e400-b4b3-11eb-80b6-4bcf64ce53a2.MOV

For now I found this work around just till the issue gets fixed for those who like to use this feature

SerpentDrago commented 3 years ago

64270408385__351ECDE4-0D04-4C0F-9A64-6D58C6886432.MOV For now I found this work around just till the issue gets fixed for those who like to use this feature

yes but that will only work on TMDB helper items (or should only work on them ) its a tmdb helper only context menu item

xyzfre commented 3 years ago

64270408385__351ECDE4-0D04-4C0F-9A64-6D58C6886432.MOV For now I found this work around just till the issue gets fixed for those who like to use this feature

yes but that will only work on TMDB helper items (or should only work on them ) its a tmdb helper only context menu item

https://user-images.githubusercontent.com/49699869/118341007-81a01b80-b4eb-11eb-8ae2-4aa630e449e5.MOV

It does work for example if I’m using a home screen Widget from venom and I have the TMDB Context menu installed I can do the same thing ,, but don’t get me wrong it will be GREAT to have that feature fixed pushing down and seeing movies and TV Shows on the same screen from that actor much quicker That was a lot of clicks LOL

inb4after commented 3 years ago

@xyzfre @adamosborne83

We've narrowed down the issue.

It seems that when installing TMDBHelper on a clean install and running it for the first time, there is a database caching issue. TMDBHelper uses a database, MyVideos119.db, to store actor lookups so they load faster the next time.

However due to the error interrupting the first-run cascade, the database becomes corrupted and caching of items does not occur properly.

The widgets on the second page are cached beforehand while the initial actor screen is loading and are looked up using the cache after the initial actor screen finishes loading, rather than a direct lookup, which is why it won't allow you to move to the next page.

The database corruption was identified because transferring MyVideos119.db from a copy of Kodi that is not affected by this bug, into a bugged copy of Kodi, the bug was fixed.

The database can be easily fixed, without needing to use a working database, using the following steps:

  1. Go to any TMDBHelper item and use the context menu option Add to Library.
  2. Go to Settings > Media settings > General > Enable Show hidden files and directories.
  3. Go to Settings > Media settings > Library > Videos > Add videos.
  4. Click Browse and navigate to the following path: Kodi folder (it might be called .kodi on Android) > userdata > addon_data > plugin.video.themoviedb.helper > movies / tvshows folder (depends on the item you added in Step 1) > Press OK.
  5. Change This directory contains to movies / tvshows (depends on the item you added in Step 1) then Press OK.
  6. Press Yes to refresh information for all items in the path.
  7. The custom actor window down press should now be working.

You can go back to Testing branch, all should be working (ActorHotFix was just a trial and error hotfix, but the actual cause of this bug wasn't the skin itself).

xyzfre commented 3 years ago

@xyzfre @adamosborne83

We've narrowed down the issue.

It seems that when installing TMDBHelper on a clean install and running it for the first time, there is a database caching issue. TMDBHelper uses a database, MyVideos119.db, to store actor lookups so they load faster the next time.

However due to the error interrupting the first-run cascade, the database becomes corrupted and caching of items does not occur properly.

The widgets on the second page are cached beforehand while the initial actor screen is loading and are looked up using the cache after the initial actor screen finishes loading, rather than a direct lookup, which is why it won't allow you to move to the next page.

The database corruption was identified because transferring MyVideos119.db from a copy of Kodi that is not affected by this bug, into a bugged copy of Kodi, the bug was fixed.

The database can be easily fixed, without needing to use a working database, using the following steps:

  1. Go to any TMDBHelper item and use the context menu option Add to Library.
  2. Go to Settings > Media settings > General > Enable Show hidden files and directories.
  3. Go to Settings > Media settings > Library > Videos > Add videos.
  4. Click Browse and navigate to the following path: Kodi folder (it might be called .kodi on Android) > userdata > addon_data > plugin.video.themoviedb.helper > movies / tvshows folder (depends on the item you added in Step 1) > Press OK.
  5. Change This directory contains to movies / tvshows (depends on the item you added in Step 1) then Press OK.
  6. Press Yes to refresh information for all items in the path.
  7. The custom actor window down press should now be working.

You can go back to Testing branch, all should be working (ActorHotFix was just a trial and error hotfix, but the actual cause of this bug wasn't the skin itself).

My apologies if I’m asking for to much, but would it be possible to show these steps in a video would really appreciated and thank you for finding the issue and all the hard work you guys do✊🏼

SerpentDrago commented 3 years ago

@xyzfre .Ill get you a video today. But adding anything to kodis library should do it even real files. This is how kodi was intended to be used (library) . What device are you on?

adamosborne83 commented 3 years ago

Well bugger me sideways....... it worked yipppeeeeeeee.

Great step by step. THANK YOU SO MUCH....

adamosborne83 commented 3 years ago

So when is the Repo coming out ;)

I don't think there is much left for me to break now haha

xyzfre commented 3 years ago

@xyzfre .Ill get you a video today. But adding anything to kodis library should do it even real files. This is how kodi was intended to be used (library) . What device are you on?

I’m using a Nvidia shield pro K19.1 ,, I don’t use library I use Trakt, after I follow these steps and get the feature working if I delete the item I added to library will the feature work afterwards or I have to have something in my library

inb4after commented 3 years ago

@xyzfre .Ill get you a video today. But adding anything to kodis library should do it even real files. This is how kodi was intended to be used (library) . What device are you on?

I’m using a Nvidia shield pro K19.1 ,, I don’t use library I use Trakt, after I follow these steps and get the feature working if I delete the item I added to library will the feature work afterwards or I have to have something in my library

The feature will continue to work, even if you delete the library item afterwards. It just needs this initial database change to start working permanently.

SerpentDrago commented 3 years ago

So when is the Repo coming out ;)

I don't think there is much left for me to break now haha

Super secret. The repo is already made (repository.auramod.aio) I've just not put the zip on a kodi filesource and remade instructions etc etc and I'm waiting for the final merge of testing into matrix

adamosborne83 commented 3 years ago

So when is the Repo coming out ;) I don't think there is much left for me to break now haha

Super secret. The repo is already made (repository.auramod.aio) I've just not put the zip on a kodi filesource and remade instructions etc etc and I'm waiting for the final merge of testing into matrix

Haha Fair Play,

Feel free to let me be one of the first to play ;)

Seriously you peeps are amazing @SerpentDrago @inb4after

JFG1000 commented 3 years ago

@SerpentDrago could you please also send me over the video if you don't mind. Many thanks

xyzfre commented 3 years ago

@xyzfre .Ill get you a video today. But adding anything to kodis library should do it even real files. This is how kodi was intended to be used (library) . What device are you on?

I’m using a Nvidia shield pro K19.1 ,, I don’t use library I use Trakt, after I follow these steps and get the feature working if I delete the item I added to library will the feature work afterwards or I have to have something in my library

The feature will continue to work, even if you delete the library item afterwards. It just needs this initial database change to start working permanently.

Followed your steps and got it working this is definitely a nice feature to have working again ,,you guys are the BEST love AuraMod can’t thank you guys enough for all the fixes these past few months you guys have put into this project it’s truly amazing✊🏼🙌🏼🙌🏼, I look forward every day to looking on GitHub for more updates LOL

SerpentDrago commented 3 years ago

@xyzfre https://youtube.com/playlist?list=PLAS0V-jJr0H-Fgn8h-j0l_O46wEOuxahs

You will need to be logged into youtube to view , cause for some stupid reason youtube age restricted the first part lol

adamosborne83 commented 3 years ago

So when is the Repo coming out ;) I don't think there is much left for me to break now haha

Super secret. The repo is already made (repository.auramod.aio) I've just not put the zip on a kodi filesource and remade instructions etc etc and I'm waiting for the final merge of testing into matrix

Repo works perfect 🍸

SerpentDrago commented 3 years ago

Repo works perfect 🍸

Instructions updated in Readme on matrix branch and repo zip added to kodi file manager source

xyzfre commented 3 years ago

This is the best I seen AuraMod work and it’s always work GREAT for me , it’s perfect👌🏼🙌🏼✊🏼

inb4after commented 3 years ago

@xyzfre .Ill get you a video today. But adding anything to kodis library should do it even real files. This is how kodi was intended to be used (library) . What device are you on?

I’m using a Nvidia shield pro K19.1 ,, I don’t use library I use Trakt, after I follow these steps and get the feature working if I delete the item I added to library will the feature work afterwards or I have to have something in my library

The feature will continue to work, even if you delete the library item afterwards. It just needs this initial database change to start working permanently.

Followed your steps and got it working this is definitely a nice feature to have working again ,,you guys are the BEST love AuraMod can’t thank you guys enough for all the fixes these past few months you guys have put into this project it’s truly amazing✊🏼🙌🏼🙌🏼, I look forward every day to looking on GitHub for more updates LOL

After further testing, if you remove that video source from library, it breaks again. The library file is very small in size, so it's worth keeping until the bug has been fixed. It seems more likely to be a Kodi bug, but I've asked jurial for more help about how TMDBHelper works when looking up information and how the Kodi video database fits into the picture.

xyzfre commented 3 years ago

@xyzfre .Ill get you a video today. But adding anything to kodis library should do it even real files. This is how kodi was intended to be used (library) . What device are you on?

I’m using a Nvidia shield pro K19.1 ,, I don’t use library I use Trakt, after I follow these steps and get the feature working if I delete the item I added to library will the feature work afterwards or I have to have something in my library

The feature will continue to work, even if you delete the library item afterwards. It just needs this initial database change to start working permanently.

Followed your steps and got it working this is definitely a nice feature to have working again ,,you guys are the BEST love AuraMod can’t thank you guys enough for all the fixes these past few months you guys have put into this project it’s truly amazing✊🏼🙌🏼🙌🏼, I look forward every day to looking on GitHub for more updates LOL

After further testing, if you remove that video source from library, it breaks again. The library file is very small in size, so it's worth keeping until the bug has been fixed. It seems more likely to be a Kodi bug, but I've asked jurial for more help about how TMDBHelper works when looking up information and how the Kodi video database fits into the picture.

Thank you for this great info luckily yesterday I didn’t bother removing the one item I added to the library so I’m glad I left it there so everything is still good on my end