search

Serranya / deadbeef-mpris2-plugin

A rewrite of the seemingly orphaned deadbeef-mpris-plugin originally written by HuangCongyu
GNU General Public License v2.0
65 stars 8 forks source link

Crash when there's no default_cover #7

Closed cboxdoerfer closed 9 years ago

cboxdoerfer commented 9 years ago

The plugin segfaults in strlen because apparently get_default_cover() returns NULL. That's the line: https://github.com/Serranya/deadbeef-mpris2-plugin/blob/master/src/mprisServer.c#L162

Backtrace: http://pastebin.com/raw.php?i=WgqKeAdA

And btw. thx for the plugin :)

Serranya commented 9 years ago

Hmm I cannot reproduce the issue on my system. On what system are you running, and which version of DeaDBeeF are you using ?

I will add a null check anyways.

Thank you for contributing :)

cboxdoerfer commented 9 years ago

System is Arch Linux and DeaDBeeF is build from trunk. I will test the fix and report if the issue remains or not. :)

Serranya commented 9 years ago

Should be fixed in 59a45a27048bf4222cea1bdb960794b7226ae7d2

cboxdoerfer commented 9 years ago

Yep, works fine. Thx :)