Serranya / deadbeef-mpris2-plugin

A rewrite of the seemingly orphaned deadbeef-mpris-plugin originally written by HuangCongyu
GNU General Public License v2.0
65 stars 8 forks source link

segfault on some files (deadbeef-git) #8

Closed Soukyuu closed 9 years ago

Soukyuu commented 9 years ago

Recently stumbled upon this plugin, thanks for implementing. I'm using archlinux x64 and have installed deadbeef-git from AUR, as well as deadbeef-mpris2-plugin.

I'm getting the following crash on some files:

MPRIS Debug Info: get Metadata duration: 288000000
MPRIS Debug Info: get Metadata album: Complication
MPRIS Debug Info: get Metadata albumArtist: (null)
MPRIS Debug Info: get Metadata artist: ROOKiEZ is PUNK’D
MPRIS Debug Info: getting cover for album Complication
MPRIS Debug Info: cover for Complication not ready. Using default artwork
Segmentation Fault
backtrace() returned 10 addresses
deadbeef() [0x403aa1]
/usr/lib/libc.so.6(+0x33540) [0x7fe0e965f540]
/usr/lib/libc.so.6(strlen+0x2a) [0x7fe0e96ac20a]
/usr/lib/deadbeef/mpris.so(getMetadataForTrack+0x7d0) [0x7fe0cf421f30]
/usr/lib/deadbeef/mpris.so(emitMetadataChanged+0x38) [0x7fe0cf422a98]
/usr/lib/deadbeef/mpris.so(+0x1cd7) [0x7fe0cf420cd7]
deadbeef() [0x404b1f]
deadbeef() [0x404e29]
/usr/lib/libpthread.so.0(+0x7374) [0x7fe0e99d6374]
/usr/lib/libc.so.6(clone+0x6d) [0x7fe0e971427d]

Removing the plugin makes the file play fine again.

Serranya commented 9 years ago

Can you test the latest git version of this plugin ?

git clone git@github.com:Serranya/deadbeef-mpris2-plugin.git
cd deadbeef-mpris-2-plugin
autoreconf --install
./configure --prefix=/usr
make
sudo make install
Soukyuu commented 9 years ago

Latest git seems to be working fine so far (the song that used to crash it now doesn't)

Serranya commented 9 years ago

Ok. I will release a new version of this plugin today to fix this issue

Serranya commented 9 years ago

The new version is released.

Soukyuu commented 9 years ago

Thank you!