${gitorigin.path,n} returns 'invalid-index'

Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.

https://marketplace.visualstudio.com/items/waderyan.gitblame

MIT License

72 stars 31 forks source link

${gitorigin.path,n} returns 'invalid-index' #110

Closed harri-halttunen-aktia closed 2 years ago

harri-halttunen-aktia commented 2 years ago

${gitorigin.path,n} seems to fail when git ls-remote --get-url command returns URL like this:

ssh://git@git.company.com/project_x/test-repository.git

${gitorigin.path,n} returns 'invalid-index' no matter what n is.

As a side note, my goal is to build a Git URL like this:

https://git.company.com/projects/project_x/repos/test-repository/commits/8477f804daea99e6738b14c7a95e080265412abe

Sertion commented 2 years ago

Hey harri-halttunen-aktia!

Thank you for reporting this. Will look into it.

Sertion commented 2 years ago

I'm currently working on a new version (8) that will change a bit how the gitorigin.path token behaves. Does the token resolves in the added test here look like you expect?

harri-halttunen-aktia commented 2 years ago

The test almost looks like what is needed. I would use this URL as an additional test case:

ssh://git@git.company.com/project_x/test-repository.git as it contains both, dash (-) and underscore (_) characters. Also, it has a subdomain (not that it necessarily matter).

Sertion commented 2 years ago

I've released a new version that should solve this problem. It will appear sometime soon™.