search

Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
72 stars 31 forks source link

commit.summary before commit.hash_short causes display bug #119

Closed Cathryne closed 2 years ago

Cathryne commented 2 years ago

Hello & 1k thanks for this neat extension :-)

As Adam in https://github.com/Sertion/vscode-gitblame/issues/94#issuecomment-718127930, I also migrated off GitLens found a new home here!

Possibly, I have stumbled upon a little bug in the gitblame.statusBarMessageFormat parsing or display: It doesn't seem possible to have commit.summary before commit.hash_short and have both displayed in that order:

vsc-gitblame-summary-bug

All the other fields I've tried get rendered as expected, and I also tried it with all other VSCode settings removed. Only that ${commit.summary} ${commit.hash_short,7} combination/order seems to cause the former to be unexpectedly hidden.

Env info 
Version: 1.64.2
Commit: f80445acd5a3dadef24aa209168452a3d97cc326
Date: 2022-02-11T00:29:32.407Z (1 day ago)
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 19.6.0 (macOS Catalina 10.15.7)
Sertion commented 2 years ago

Hello Cathryne!

Fascinating bug! I have been able to recreate it.

Sadly I have no idea when I will have the time to look into it at any length.

Sertion commented 2 years ago

I could not let this go and I took some time to look into what could be the issue. Luckily for everyone I found the issue almost instantly.

I still do not know when I will be able to release a new version of the extension.