search

Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
72 stars 31 forks source link

Inline message drawn on top of code when backspacing from EOL #142

Closed kgalford1 closed 1 year ago

kgalford1 commented 1 year ago

Versions

vscode v1.78.1 with all extensions disabled except for Git Blame v10.2.0. Bug appears to be introduced with inline blame string in v10.0.0.

image

image

Example

Cursor at EOL 82. image

Backspacing the \n on 82. image

Continuing to backspace and the + 45 is drawn underneath the inline message. image

Sertion commented 1 year ago

Hey Kim. Thanks for the detailed bug report!

I did not implement the line decorator feature and do not know how it works but perhaps I'll have some time to look into this in the near future.

kgalford1 commented 1 year ago

No worries - I have virtually no experience with extension dev, but perhaps may look into this as well.

Loving the extension - with this fix it's all the blame functionality from GitLens I need :smile:

Sertion commented 1 year ago

I had some time and I think I got it working. Will spend some more time looking into a fix for #144 before releasing a new version.

stevemandl commented 1 year ago

This might be the same issue, so I thought you would want to test this case too before deploying a fix. It also happens when deleting a newline on a blank line: image and after hitting the delete key: image I'm running v10.2.0 on WSL: Ubuntu

thijsputman commented 1 year ago

A (sort of) workaround is to configure the following:

"gitblame.inlineMessageNoCommit": ""

This blanks out the blame-message on modified lines – (mostly) preventing the issue from occurring in the first place.

Might this be a sensible configuration option to introduce? Omitting the message on modified lines provides effectively the same information as showing "Not Commited Yet"...

Sertion commented 1 year ago

A new version that fixes this issue has been pushed to the marketplace. It can sometimes take a few hours for it to be available for everyone. I will close this issue for now. Please comment if the issue persists after upgrading to version 10.2.1 or later.