Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
72 stars 31 forks source link

A subtle color for inline blame? #145

Closed aaravind100 closed 1 year ago

aaravind100 commented 1 year ago

Hey @Sertion , Good day!!

Would a more subtle color for the inline blame make sense or maybe an option to set a custom color code?

Presently the color is set by the editorCodeLens.foreground here. This looks good with the default theme, but looks prominent in some themes, rose pine for example.

image

image

image

This is indeed trying to emulate the style from gitlens, which has become quite bloated lately :sweat_smile:

I'd be happy to submit a pr for this.

vscode version: 1.79.2
extension version: v10.2.0
Sertion commented 1 year ago

Hey Ajith.

Chasing the perfect color for each theme is a Sisyphean task. editorCodeLens.foreground was chosen because it is the color used when showing information about the code in the editor. It should be possible to override this color in your settings.

aaravind100 commented 1 year ago

I understand, thanks for the suggestions :smile:

redactedscribe commented 7 months ago

@Sertion Could it be possible to change which colour the inline blame references? E.g. to point it at the theme's comment colour variable instead? The comments are usually more subtle than the foreground text. Instead of hardcoding foreground vs comment colour, perhaps leave it up to the user to define which colour variable to use? Thanks for Git Blame!

Sertion commented 7 months ago

The comments are usually more subtle than the foreground text. Instead of hardcoding foreground vs comment colour, perhaps leave it up to the user to define which colour variable to use? Thanks for Git Blame!

Sadly there is no good way of allowing a "color" as a setting and writing something to detect what random color-like string the extension has gotten through a setting is not something I'm interested in exploring.

Sertion commented 5 months ago

Implemented in #168.

aaravind100 commented 5 months ago

Thank you!!

FYI for anyone reading this, we should add this to settings.json to use a custom color.

    "workbench.colorCustomizations": {
        "gitblame.inlineMessage": "<hex color code>"
    }