Plural string for 1 of thing (e.g. "1 months")

Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.

MIT License

75 stars 32 forks source link

Closed adambowles closed 7 years ago

adambowles commented 7 years ago

Example can be seen in your example gif

adambowles commented 7 years ago

I recommend using moment to manage this for you

Sertion commented 7 years ago

Hey Adam, thank you for the issue and PR!

Right now there is a token for moments timeFrom function: ${time.from}

I will look into fixing the plural/singular issue.

Sertion commented 7 years ago

I just got back home and started looking into this.

Is this still an issue or is it only an issue in the demo gif?

adambowles commented 7 years ago

Yeah it's currently in 1.10.0, it was just easier to use the gif to demonstrate visually

Sertion commented 7 years ago

But only for months, right?

Will release a new version after some further testing.

adambowles commented 7 years ago

Not just 'months'; you can see all time units have plurals here

Sertion commented 7 years ago

Thanks for being persistent here. For some reason I thought it never could render with one day or one hour.

adambowles commented 7 years ago

No problem 👍