search

Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
72 stars 31 forks source link

`gitblame.delayBlame` triggers for each character typed #160

Closed redactedscribe closed 6 months ago

redactedscribe commented 7 months ago

The delay in its current state is only useful (accurate) the moment you click on a line. Once you start typing, it creates a new timer for the next X seconds, per character typed. You'll notice that the inline blame keep appearing much sooner than the delay value set.

Thanks.

v10.5.1

Sertion commented 7 months ago

Hey redactedscribe. Thanks for the bug report.

I'll see what I can do. Sadly it is not possible to know what type of text change or selection change the user does with the vscode extensions API.

Sertion commented 7 months ago

I was not able to reproduce the issue but I saw some possible changes to mitigate the behavior you are describing. Attached to this post is a pre-release build. If you could test it and verify that the issue is resolve that would be very appreciated!

gitblame-10.6.0-pre-release.zip

redactedscribe commented 7 months ago 
    "gitblame.inlineMessageEnabled": true,
    "gitblame.delayBlame": 3000,
  1. Click on a line and wait 3 seconds. Blame appears.
  2. Type a letter every second for 10 seconds. Notice blame appears on the line after 3 seconds, and keeps disappearing and reappearing after every letter typed even though only 1 second is passing between presses.

Blame should only appear 3 seconds after the last letter typed.

Sertion commented 6 months ago

Sorry for the way. A new version with the change has been pushed to the marketplaces. It should become available in the next hours/days.

Thank you for the bug report and feedback!

redactedscribe commented 6 months ago

And thank you for the fix!