Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
75 stars 32 forks source link

The "git.path" property is not an executable #22

Closed sheafitzek closed 7 years ago

sheafitzek commented 7 years ago

I keep getting this error at the top of the window.

The "git.path" property is not an executable

In the output console, it says:

critical ] Error: Can not execute "/usr/bin/git"

The git.path is set to "usr/bin/git" & I don't have problems with any other extensions that use git. I'm on Kubuntu 16.04 x64 if it helps.

Sertion commented 7 years ago

Hey Shea!

Is /usr/bin/git executable on your system?

I use FS.accessSync(commandPath, FS.constants.X_OK) to check if the file can be executed before trying to do so and the error you are seeing tells me that it is not. What happens if you set your git.path property to null?

Sertion commented 7 years ago

I have released an update that relegates the message to only the log.

I hope this will be a better solution. 😃

sheafitzek commented 7 years ago

Thanks for removing that message from the top of the window. FYI...usr/bin/git is executable (755) on my system...now the message I get in the output console is:

error ] Error: Can not execute "/usr/bin/git" (your git.path property) falling back to "git"

It does seem to be working now, though.