Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
75 stars 32 forks source link

Include ${commit.linediff} #24

Closed admirabilis closed 6 years ago

admirabilis commented 6 years ago

It would be interesting if upon clicking on the status bar, the user could see a small diff of the line. Git Lens has something similar as popup over each line, but I find it very intrusive. So I believe that just a ${commit.linediff} variable (with the possibility of placing it in a new line) would be more than enough!

Sertion commented 6 years ago

Hey teresaejunior!

I am not sure if I understand exactly what it should display. Could you tell me what should be returned for this change in gitcommand.ts?

admirabilis commented 6 years ago

Taking the example from Git Lens, the variable would return the following text:

-        ErrorHandler.getInstance().logCritical(new Error(`Can not execute "${commandPath}"`), 'The "git.path" property is not an executable');
+        ErrorHandler.getInstance().logError(new Error(`Can not execute "${commandPath}" (your git.path property) falling back to "${GIT_COMMAND_IN_PATH}"`));

linediff

If that is difficult to implement, maybe a variable that just contains - return code; could be interesting.

Sertion commented 6 years ago

I have had time to do some further research here and it is not possible to have line breaks in a window.showInformationMessage.

I will not add this feature unless something changes in the future.