search

Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
72 stars 31 forks source link

Exception UriError thrown when running "quick info" and "view online" commands #34

Closed maaarghk closed 5 years ago

maaarghk commented 6 years ago

I have a repo in which running the above noted commands results in this:

screen shot 2018-05-30 at 00 23 19

The output pane shows this: [ 00:22:05 | command ] /usr/local/bin/git ls-remote --get-url origin The result of which, when run in a terminal, follows the following format: git@git.someserver.com:user/repository

Changing the remote to the format ssh://git@git.someserver.com/user/repository makes the extension work.

This relates to issue https://github.com/Microsoft/vscode/issues/38696 but that is closed. It is wrong to treat 'scp' style URIs like the format above as URIs per the rfc3986 spec, but I don't really know if this is an example of this extension misusing the vscode URI class or if there should be a pull request/issue raised on vscode to make that class recognise scp URIs.

Either way I feel like this extension should recognise the "scp-like" syntax as it is totally valid to use per the git documentation, and is also what most people will end up with usually since it's what github and others recommend when cloning by ssh:

screen shot 2018-05-30 at 00 38 34
Sertion commented 6 years ago

Hello maaarghk!

Thank you for the issue.

The way we currently find what link to give to the user is rather crude and you are more than welcome to create a pull request with a better version!

SpikeShape commented 5 years ago

I am having the same problem. I remember it being functional in the past but at some point it stopped working. Just now I realized that it works for me when I am working with github repositories but not with those at work.

Sertion commented 5 years ago

Closed by #44

Please create a new issue if the problem persists.