search

Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
79 stars 32 forks source link

Create web url from remote url with no .git suffix #44

Closed dewe closed 5 years ago

dewe commented 5 years ago

When working with golang and the go get command, the repositories are being created with origin remote urls that are not ending with .git.

When using the git@ protocol for a repo with no .git suffix, vscode-gitblame threw an error: [UriError]: Scheme contains illegal characters.

This pull request fixes that, and adds a few tests around the behaviour.

Sertion commented 5 years ago

Hey Johan!

Thank you for your bug report and pull request! Will try to get a new version out in a day or two.

dewe commented 5 years ago

Tack Albin

Yottster commented 5 years ago

This should close #34

Sertion commented 5 years ago

Closed the issue. Thank you Viktor!