Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
79 stars 32 forks source link

Stop using an EventEmitter for blame processing #58

Closed Sertion closed 4 years ago

Sertion commented 5 years ago

We currently use an EventEmitter to tell GitFilePhysical about commits and hashes that the git blame process has found. The issue with this is that it isn't possible to properly type this without adding a lot of complexity. When vscode upgrades to Electron 6 the AsyncIterator in streams will no longer be marked as experimental and we can investigate using that. It should allow us to properly type the transaction.