Implement date token for author and committer

Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.

MIT License

79 stars 32 forks source link

Closed abarichello closed 4 years ago

abarichello commented 5 years ago

Hello there, i've implemented the date token as an alternative to time.ago since the date estimation is sometimes rounded and not exactly precise.

Let me know if this PR needs any extra changes.

abarichello commented 4 years ago

@Sertion

Sertion commented 4 years ago

Thank you for the pull request. Here is some feedback:

Is there a reason to use toDateString over the iso variant? The iso variant will never require any localisation, follows a standardized format, and is still equally accurate.
The current implementation includes and extra trailing whitespace at the end of the token.

// S

abarichello commented 4 years ago

@Sertion Done

Sertion commented 4 years ago

Thank you. That was quick!

I don't know when I can get the next version out. There are some blockers for me right now but this will be part of the next release.

abarichello commented 4 years ago

No problem. Thanks!