Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
75 stars 32 forks source link

Nothing shown in bar #9

Closed adambowles closed 7 years ago

adambowles commented 7 years ago

Updated from 1.5 -> 1.8.0 this morning. Extension now shows nothing in the bar, while it was working before this weekend's updates

Sertion commented 7 years ago

Hey Adam.

I am unable to reproduce this issue in any of my test environments.

Have you tried shutting down vscode and launching it again? What operating system are you using? Is the git repository you are using old or contains a lot of commits? If so, have you waited for a few seconds to see if the information appears?

adambowles commented 7 years ago

Here are my other extensions:

image

adambowles commented 7 years ago

Is it possible to install older versions so I can find the exact commit that broke?

Sertion commented 7 years ago

If you are willing to do some testing locally you can check out the code and run npm install followed by npm install -g vsce, checkout the commit you want to build and run vsce package to get an installable file that you can install using Extension: Install from VSIX.

Help would be greatly appreciated.

pftbest commented 7 years ago

Hello, I have the same issue, will try to debug

adambowles commented 7 years ago

@Sertion thanks, I'm running locally compiled versions atm

pftbest commented 7 years ago

@Sertion, Found the issue, you have replaced textdecorator with textDecorator in commit https://github.com/Sertion/vscode-gitblame/commit/d616b1a6180c5285e5773a2051c448cfda142180

But the file name is still in lower case, so it can't find it. This should be easy fix, but I can submit a pull request if you like.

adambowles commented 7 years ago

@pftbest I agree

Mine wouldn't even compile without that change,

I guess you're developing on Windows @Sertion?

Sertion commented 7 years ago

Thank you for your help!

A pull request would be welcomed. I will have some time in a few hours.

I guess you're developing on Windows @Sertion?

Either a Mac or a Windows computer.

vojtechhabarta commented 7 years ago

Thanks for reporting and fixing this bug.

I think this type of errors can be prevented by using forceConsistentCasingInFileNames TypeScript compiler option.