Sertion / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
72 stars 31 forks source link

"Waiting for git blame response" (5.0.1) #92

Closed dominikzogg closed 3 years ago

dominikzogg commented 3 years ago

The Version 5.0.1 broke the extension for me (it successfully show the committer, but click on it shows "Waiting for git blame response" instead of opening a notification with a link to github (in my case)

Within console i get:

mainThreadExtensionService.ts:65 [[object Object]]Invalid URL: git@github.com:account/project.git
$onExtensionRuntimeError @ terminalInstanceService.ts:31
_doInvokeHandler @ rpcProtocol.ts:401
_invokeHandler @ rpcProtocol.ts:332
_receiveRequest @ rpcProtocol.ts:278
_receiveOneMessage @ rpcProtocol.ts:220
(anonymous) @ rpcProtocol.ts:93
fire @ event.ts:535
fire @ ipc.net.ts:407
_receiveMessage @ ipc.net.ts:755
(anonymous) @ ipc.net.ts:630
fire @ event.ts:535
acceptChunk @ ipc.net.ts:224
(anonymous) @ ipc.net.ts:149
t @ ipc.net.ts:892
emit @ events.js:223
addChunk @ _stream_readable.js:309
readableAddChunk @ _stream_readable.js:290
Readable.push @ _stream_readable.js:224
onStreamRead @ internal/stream_base_commons.js:181
mainThreadExtensionService.ts:66 TypeError [ERR_INVALID_URL]: Invalid URL: git@github.com:account/project.git
    at onParseError (internal/url.js:243)
    at new URL (internal/url.js:319)
    at _ (/path/to/extension/waderyan.gitblame-5.0.1/dist/index.js:57)
    at q (/path/to/extension/waderyan.gitblame-5.0.1/dist/index.js:67)
    at processTicksAndRejections (internal/process/task_queues.js:94)
    at async W.showMessage (/path/to/extension/waderyan.gitblame-5.0.1/dist/index.js:78)

My guess, the change works only with http(s) but not with ssh.

shelmire commented 3 years ago

Same here.

Sertion commented 3 years ago

Hey Dominik and Alex!

Thank you for the report and for the stack trace! I will look into this immediately.

Sertion commented 3 years ago

I've released a new version with a fix for this issue and a few other things I was working on. Please report back with any further issues you find!

It can sometimes take a few hours before a new version gets pushed to everyone and sometimes you need to restart vscode to make it check for updated extensions.

Thanks again for the report!

dominikzogg commented 3 years ago

@Sertion works! thank you