[feature request] Inline view of gitblame

[kramarz89]

Hi,

Would really like to see the blame inline instead of bottom of the screen, would that be possible?

Thanks!

[Sertion]

Hello Adam.

Thank you for the request.

If this is a feature you would like I believe it is available in GitLens.

[kramarz89]

Completely right, However I prefer yours :D Since that's the only feature I need, and other gitlens features break stuff in my environment, had to disable the addon completely

BR, Adam

śr., 28 paź 2020 o 19:26 Albin Jacobsson notifications@github.com napisał(a):

Hello Adam.

Thank you for the request.

If this is a feature you would like I believe it is available in GitLens https://marketplace.visualstudio.com/items?itemName=eamodio.gitlens.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Sertion/vscode-gitblame/issues/94#issuecomment-718124989, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABR2HXAB22XHZ7XM6AWTVWTSNBO7BANCNFSM4TAPQKKQ .

[Sertion]

I am not able to look into this for a while, but I will leave the ticket open.

I think window.createTextEditorDecorationType is used for this type of feature.

[f4n0]

Hi, It will be very useful for me too! I've created a fork and added this feature, if you like it I could create a pull request

https://github.com/f4n0/vscode-gitblame

Let me know if this helps you!

[Sertion]

Hey f4n0. Looks good so far.

If you create a PR I can have a look and do some clean up.

If you want to do it yourself here are some comments:

• Please use a ThemeColor for the decorator
• Please refrain from using global variables and please add decorationType to the Extension class' disposables
• I think it should be fine to add setDecorations to PartialTextEditor
• I would love a constant or something that gives a name to the magic number (1024) in new Position(editor.selection.active.line, 1024),

[f4n0]

I've modified it as you asked! (sorry but I'm not in the world of vscode extension developments!)

[andrewk-grabyo]

Excited to see this extension get the inline blame feature!

[JuanEL0]

This extension is really great, and like @kramarz89 I just want the inline blame so thanks @f4n0 for your time and effort

[Sertion]

I just uploaded the new version to the marketplace. It sometimes can take a few hours for it to appear for everyone.

If you want to enable the feature there is a setting.

Thank you to everyone for your help and to @f4n0 specifically for the great PR!

[JuanEL0]

Awesome extension, thank you @Sertion!!!