search

Serubin / pulse-sms-web

The official web app for Pulse SMS - built on Vue.js.
https://pulsesms.app
Other
109 stars 44 forks source link

Move from vue-ajax to axios #107

Closed Serubin closed 4 years ago

Serubin commented 4 years ago

Summary

Switch ajax library from vue-h-ajax to axios.

Motivation

The motivation for this encompasses two things - 1) Testability - testing with the Vue context is annoying and not necessary 2) Maintainability - vue-ajax has very little support

Test Plan

Click testing... for now.

klinker24 commented 4 years ago

🙌 I love axios, it works great. I will take a look at this and test it out, tomorrow 👍

Serubin commented 4 years ago

The API doesn't return any other status codes than 200 correct?

Serubin commented 4 years ago

^ doesn't matter.

Resolved the issue

klinker24 commented 4 years ago

The only other status code that the API returns is 401 unauthorized. Unless there is some sort of exception that happens, obviously. Looks good to me, thanks!