Serubin / pulse-sms-web

The official web app for Pulse SMS - built on Vue.js.
https://pulsesms.app
Other
109 stars 44 forks source link

Added custom notification abstraction & fixed notifications for firefox #124

Closed Serubin closed 4 years ago

Serubin commented 4 years ago

This is a mess... but this should actually fix notification abstraction. Notifyjs simply doesn't work and is NOT a polyfil (it is out of date).

Notifyjs added additional errors on electron & other non-standard browsers. It also broke event handling completely. It did however bring to light issues with firefox notifications not working. This has been fixed.

This provides a basic polyfill and renables notification support fo firefox.

This does NOT fix issues with the samsung notification api relating to service workers: Notification': Illegal constructor. Use ServiceWorkerRegistration.showNotification()