search

Serubin / pulse-sms-web

The official web app for Pulse SMS - built on Vue.js.
https://pulsesms.app
Other
109 stars 44 forks source link

Fix bad thread id issues #128

Closed Serubin closed 4 years ago

Serubin commented 4 years ago

Summary

There are several issues that rooting from this line: https://github.com/klinker-apps/pulse-sms-web/blob/a124a30731114e03b9a1e810efb89a8b9c1cb2bc/src/components/Thread/Thread.vue#L70 This occurs when either the thread route is wrong, or when the conversation cache is invalid or out of date, this will error.

Reproduction for cache issue

In one tab run the following in console (repalce thread id where necessary)

const conv = JSON.parse(localStorage.conversations)
conv[19168418653121] // Verify exists
delete conv[19168418653121] // Delete from cache
localStorage.setItem("conversations", JSON.stringify(conv))

In another tab load /thread/19168418653121 with console open - this should error

Logged issues

https://app.bugsnag.com/pulsesms/pulse-sms-web/errors/5e61bd2f50a8a80018c57182?filters[error.status][0]=open https://app.bugsnag.com/pulsesms/pulse-sms-web/errors/5e61c7e8c354bb001871565d?filters[event.since][0]=30d&filters[error.status][0]=open