Serubin / pulse-sms-web

The official web app for Pulse SMS - built on Vue.js.
https://pulsesms.app
Other
109 stars 44 forks source link

WIP: Auto complete contacts #36

Closed klinker24 closed 6 years ago

klinker24 commented 6 years ago

Todo:

Serubin commented 6 years ago

This did not seem ready to merge - it was not fully functional. My two concerns are you are not able to backspace over an existing chip as you previously were and you can't type in numbers not in the contact list.

The other minor item is the styling does not seem to be correct.

klinker24 commented 6 years ago

I did the inputting numbers not in the contact list, today. That is now complete, you can type any number you want and it will convert it to a chip when the input loses focus. You can type in multiple numbers as well, separated by a semi-colon or comma, and they will be converted to the chips

I had not done anything with the backspace though, guess I hadn't considered that, or knew that the original implementation did it. That should be easy enough though. I can add it

klinker24 commented 6 years ago

I definitely agree that the styles can be improved in the future though. It was pretty tough to make it look right, having to add the chips to the left of the input.

I found that, with the old implementation, the input box wouldn't allow for more than 5 or so contacts, because it couldn't scroll horizontally or vertically. So, when the chips filled the whole line, there wasn't a way to input additional contacts. So, the new version will just have a single line of chips and the input box, that will scroll horizontally as it fills up