search

Serubin / pulse-sms-web

The official web app for Pulse SMS - built on Vue.js.
https://pulsesms.app
Other
109 stars 44 forks source link

Upgrade to Webpack 4 #61

Closed klinker24 closed 5 years ago

klinker24 commented 5 years ago

I am working on #28. To get the web workers working through webpack, we needed to upgrade to webpack v4. This should do that.

@Serubin if you get a chance, can you try this out and make sure it is working for you in both dev/production? It seems to be working alright, but an extra set of eyes would be great.

Serubin commented 5 years ago

This appears to be good!

Serubin commented 5 years ago

I did get a Deprecation Warning, but not a huge deal. 

(node:42993) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
klinker24 commented 5 years ago

Yeah that warning is coming from one of the plugins that hadn't been updated for webpack 4 yet. Still working fine though, so I am not concerned about it at this point