search

Serubin / pulse-sms-web

The official web app for Pulse SMS - built on Vue.js.
https://pulsesms.app
Other
109 stars 44 forks source link

Improve Decryption Worker #86

Closed Serubin closed 5 years ago

Serubin commented 5 years ago

This was meant to be more impressive - but I wasted a day and couldn't create the improvements I wanted.

For tracking my original intent was to:

Instead: We're just terminating the worker once it's job has been completed.

klinker24 commented 5 years ago

I had so many issues getting these set up and definitely wasted about that much time on it too. While I am disappointed you weren't able to get to the original intent, it makes me feel a bit better that I wasn't able to set it up that way from the start....

Serubin commented 5 years ago

Happy to assist hah.

I consistently ran into two issues: 1) When I used our pre-built aes objects from the vuex store, inexplicably a.decrypt from sjcl didn't work. This occurred pretty consistently. 2) Scoping on a single worker was a nightmare. It seems as though the items were being passed by reference to the worker, which doesn't make any sense on it's own.

klinker24 commented 5 years ago
  1. was absolutely infuriating for me. Couldn't understand it at all
  2. yeah, I really don't have a clue on that one.

I am just going to accept what we have here. I don't plan on diving back in to them, at least! It is a really cool way to do the decryption, and I am glad that it works, but I just don't think we need to spend any more time on it at this point.