Serubin / pulse-sms-web

The official web app for Pulse SMS - built on Vue.js.
https://pulsesms.app
Other
109 stars 44 forks source link

Enter phone numbers not in the contact list #98

Closed klinker24 closed 4 years ago

klinker24 commented 4 years ago

It does a few weird things, that I want to track here.... I have some stats on how often people send messages to numbers not in their contact list, and it is rarely. If they do, it is almost always a either a single phone number, or a huge list of phone numbers (that they obviously copied from a spreadsheet or something). With those stats in mind, I have no problem pushing this feature with these oddities. It seems like I will need to edit the library, to fix these things. I have no problem doing so, but it isn't top priority for me.

  1. Say you type a phone number and tokenize it by ending with ;. If you then try to type someone's contact name and complete it through the auto complete, it will wipe out the phone number you typed. The multi-select-list appears to manage the list of selected items by itself and provides the list, without the tokenized numbers.
  2. Say you type a few different phone numbers into the contact entry. If you go to delete one of the chips, it deletes them all. Same issue as the last item. The library isn't tracking the extra items I append to the selected list.

I could just track the items separately and add them to the list whenever a change is made, but I do not know how I would go about allowing the user to delete them, in that case.