Serubin / pulse-sms-web

The official web app for Pulse SMS - built on Vue.js.
https://pulsesms.app
Other
109 stars 44 forks source link

Change v-show to v-if for audio and video messages #99

Closed BenMcH closed 4 years ago

BenMcH commented 4 years ago

This PR addresses an issue in which messages without video are covered with a speed overlay, making the messages impossible to read. This is caused by the video element on every message. I went ahead and changed the v-show on these to v-if, that way media is still shown properly.

Before: Hard to read text

After: image

Example of message with video still rendering correctly: image