In SettingsOnEF, we plan to add comments into the json files that were generate by the Json data provider. The original objective was to add comments into an already written json files whenever settings would change. But in beginning the implementation, I was finding that I needed (in the SettingsOnEF repo) to duplicate a lot of the logic on how our json ADO.NET Provider stores to disk. Therefore, it would be better if SettingsOnEF core could just derive its own DataSetWriter and inject it for use. Currently the idea is to provide a abstract factory method on FileConnection<> that returns an IDataSetWriter and is called by each writer class. SettingsOnEF can then derive both off of JsonConnection and JsonDataSetWriter. Our EF Core provider extensions like UseJson() have an overload that allows for one to provide the JsonConnection.
Also part of this task:
Ignore JSON comments in JSON files when our reader is reading them.
In SettingsOnEF, we plan to add comments into the json files that were generate by the Json data provider. The original objective was to add comments into an already written json files whenever settings would change. But in beginning the implementation, I was finding that I needed (in the SettingsOnEF repo) to duplicate a lot of the logic on how our json ADO.NET Provider stores to disk. Therefore, it would be better if SettingsOnEF core could just derive its own DataSetWriter and inject it for use. Currently the idea is to provide a abstract factory method on FileConnection<> that returns an IDataSetWriter and is called by each writer class. SettingsOnEF can then derive both off of JsonConnection and JsonDataSetWriter. Our EF Core provider extensions like UseJson() have an overload that allows for one to provide the JsonConnection.
Also part of this task: