search

Servarr / Wiki

328 stars 59 forks source link

Updates to install/uninstall scripts. #349

Closed nostrus-dominion closed 6 months ago

nostrus-dominion commented 6 months ago

I've been using this project on and off for a little over a year now and I wanted to contribute to the project in a small way.

I made some changes to these scripts to make them more readable and give it a bit of flair. The big thing is change a lot of how the confirmations work and what the user has to do to make sure they are doing what they mean to be doing.

For example to continue the script after making a selection for the installation is to type out "yes" during the prompt. This way the user isn't just mashing ENTER to get things going.

I also tried to make things very clear on what needs to be done after the installation in terms of R/W permissions for the directories that is needed for these services to work. Maybe we can work on adding ACL or chown later down the road?

Anyway I hope I can help out in the future and if you have any questions let me know.

nostrus-dominion commented 6 months ago

I'll get on the other things shortly but I'm in the middle of another project. Should be ready by 1700 ET

bakerboy448 commented 6 months ago

Preciate the prettifying!

nostrus-dominion commented 6 months ago

Is there anything else that would be good to work on?

bakerboy448 commented 6 months ago

applying similar changes upstream to Sonarr's install script and maybe adding an uninstall script in Sonarr/Sonarr repo would be about all that comes to mind