search

ServerPress / clean-import

Prepare and clean archives for import into DesktopServer.
2 stars 0 forks source link

# defines that have a ? seperating them and are on a single line #6

Closed GreggFranklin closed 7 years ago

GreggFranklin commented 7 years ago

This happens regardless of Clean Import. So this should probably be moved to DS3 or DS4 for resolution. This happens with Multisite.

screen shot 2017-06-08 at 10 14 49 am

Attached is the wp-config.php file to review. wp-config.php.zip

davejesch commented 7 years ago

Added code to normalize the line endings. The 'odd' character was a x0D, while all other line endings were x0Dx0A. Normalizing the line endings should solve the problem. Need to do testing on Mac.

By the way, this is not specific to MultiSite. Looks like it's caused by inconsistent line endings (some with CRLF and some with LF) on Mac. If it can be reproduced with a MS archive, please provide that so I can test and ensure the fix I have resolves it.

GreggFranklin commented 7 years ago

Ran a test creating a new multisite using the Clean Import Plugin, the result was the same.

screen shot 2017-06-13 at 12 47 00 pm

davejesch commented 7 years ago

Appears to be happening when DS creates the wp-config with MultiSite settings, it writes some line endings as 0x0D and not 0x0D 0x0A. Issue seems to be in the Xojo code that modifies wp-config.php for MultiSite.

davejesch commented 7 years ago

fixed with changes that Steve made here https://github.com/ServerPress/DS4/issues/123

GreggFranklin commented 7 years ago

Tested, and now works correctly