search

ServerPress / local-ssl

Allow DesktopServer to use SSL
4 stars 2 forks source link

Use native binaries in future release #1

Closed Steveorevo closed 6 years ago

Steveorevo commented 6 years ago

When platform native binaries are present, we should change the path to use them in core vs. shipping native platform binaries in the plugin. This will avoid redundant and irrelevant native code on incompatible platforms.

shadowdao commented 6 years ago

Agreed, we use this for OSX, but Windows doesn't appear to have a compatible version of openssl.

On Tue, May 15, 2018, 4:57 PM Stephen J. Carnam notifications@github.com wrote:

When platform native binaries are present, we should change the path to use them in core vs. shipping native platform binaries in the plugin. This will avoid redundant and irrelevant native code on incompatible platforms.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ServerPress/local-ssl/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ACkCsI9rR_Oyhj_eObtFhXPT38NZfVuSks5ty2t6gaJpZM4UAcoZ .

shadowdao commented 6 years ago

Looking more into this, I think issue #2 resolves this the best we can. We already using OSX's OpenSSL, but every solution for Windows Requires OpenSSL to be installed.