ServiceNow / Fast-LLM

Accelerating your LLM training to full speed
https://servicenow.github.io/Fast-LLM/
Other
37 stars 5 forks source link

[build] cpp compile during setup #32

Closed tscholak closed 2 weeks ago

tscholak commented 3 weeks ago

โœจ Description

We can let setuptools build the cpp code. That's much cleaner, see #29 for more details.

Closes #29

๐Ÿ” Type of change

Select all that apply:

๐Ÿ“ Changes

List the key changes introduced in this PR:

  1. Add cppbind11 dependency
  2. Move cpp build to setup
  3. Update Dockerfile

โœ… Checklist

Make sure the following tasks are completed before submitting the PR:

General:

Dependencies and Configuration:

Testing:

Performance Impact:

๐Ÿ“Š Performance Impact Details

N/A


๐Ÿ“ Additional Notes

N/A

tscholak commented 3 weeks ago

Sounds like a good idea, I'll see to it

tscholak commented 2 weeks ago

Looks great, but how about we move the compile to [CORE]?

I looked into it. I couldn't figure out how to do it. If I do, I'll make another attempt. Right now it doesn't seem to be worth chasing this.