"url" property and "installInstance" input expected by the batch-install action

ServiceNow / sncicd-batch-install

MIT License

8 stars 5 forks source link

"url" property and "installInstance" input expected by the batch-install action #4

Open ramyaramdasan opened 3 years ago

ramyaramdasan commented 3 years ago

Hi,

I was trying to run batch-install and ran into a few issues:

It expects a "url" property which I'm not sure where to configure and what value should be assigned to it. Kindly help.

The below error got cleared when I set the nowinstallInstance (There was no mention of this input on the documentation) to the instance where I wanted the app versions to be installed and changed the nowSourceInstance to another instance name. Wonder if there is any need to have a source instance as the application will be picked from the App Repo.

Thanks Ramya

chiarng commented 3 years ago

Our documentation needs to be updated, thanks for catching this. https://github.com/ServiceNow/sncicd-batch-install/search?q=nowinstallinstance

nowSourceInstance is not required. Only nowInstallInstance is.

ramyaramdasan commented 3 years ago

Thanks @chiarnglin! What about the "url" property? My pipeline still fails with this error:

chiarng commented 3 years ago

Sorry, I misunderstood your previous post and thought this one cleared when you had the nowInstallInstance variable set!

I'm looking at https://github.com/ServiceNow/sncicd-batch-install/blob/cd0fe0c6cf7d8bf5baab47c8de34f98540b67a9d/src/App.ts#L133

I'm not really sure what's going on, the error message seems to be a pretty typical one for node. What's the exact config of your step?

ramyaramdasan commented 3 years ago

Hi @chiarnglin,

This is how I have configured the step: steps:

uses: actions/checkout@v2
name: Batch Install id: sncicd-batch-install # id of the step uses: ServiceNow/sncicd-batch-install@2.0.1 with: source: file filename: manifest.json env: nowUsername: ${{ secrets.SN_USERNAME }} nowPassword: ${{ secrets.SN_PASSWORD }} nowInstallInstance: ${{ secrets.SN_ACC_INSTANCE }}

bmeeder22 commented 3 years ago

I am wiling to bet that the issue is happening here:

https://github.com/ServiceNow/sncicd-batch-install/blob/cd0fe0c6cf7d8bf5baab47c8de34f98540b67a9d/src/App.ts#L190

Reason being that while the batch install API is still in progress it will not have any results. Meaning that in result.links.results.url the result.links.results will be null/undefined which then means that calling .url on it will cause the error you see above and fail the whole action.

ramyaramdasan commented 3 years ago

Hi @chiarnglin,

Is this issue fixed? I tried the pipeline and it continues to fail with same error. Do I need to make any changes in the pipeline code? We would like to test batch-install method as we face often issue with parallel deployments. Greatly appreciate your help here.

Thanks Ramya