Open chelming opened 1 year ago
if we integrate that api we have only 250 limit per month right?
Yes, though I would be shocked if we run into that limit.
I don't think it should happen every time. I suggest trigger with a πΆ or π΅ reaction.
just make sure to have a failure path so the bot can explain why it didn't run
Why not just leverage the oob currency conversion?
if you add a record to fx_currency_instance
with the amount and currency and set the reference currency to the one you want to convert to it will automatically fill in the reference amount with the converted value.
There are only 5 currencies active oob, but we could turn on the full list and the exchange rates update nightly.
Maybe Chris is using Slacker for forex trades and needs real time data.
On Wed, Oct 2, 2024, 01:31 eriemer1 @.***> wrote:
Why not just leverage the oob currency conversion? if you add a record to fx_currency_instance with the amount and currency and set the reference currency to the one you want to convert to it will automatically fill in the reference amount with the converted value.
There are only 5 currencies active oob, but we could turn on the full list and the exchange rates update nightly.
β Reply to this email directly, view it on GitHub https://github.com/ServiceNowDevProgram/SlackerBot/issues/276#issuecomment-2387662574, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBGRXJYLTDKOFQE6OLADRDZZOAKNAVCNFSM6AAAAABO5P3HGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBXGY3DENJXGQ . You are receiving this because you commented.Message ID: @.***>
Yes, though I would be shocked if we run into that limit.
I don't think it should happen every time. I suggest trigger with a πΆ or π΅ reaction.
did you mean if we ran out free service then we just show the currency emoji?
No I mean a reaction using the emoji is used to trigger the bot, rather than it being a text based trigger.
On Wed, Oct 2, 2024, 08:02 K Narasimha Reddy @.***> wrote:
Yes, though I would be shocked if we run into that limit.
I don't think it should happen every time. I suggest trigger with a πΆ or π΅ reaction.
did you mean if we ran out free service then we just show the currency emoji?
β Reply to this email directly, view it on GitHub https://github.com/ServiceNowDevProgram/SlackerBot/issues/276#issuecomment-2388470417, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBGRXMTR6NY42QFORB6AJ3ZZPOG7AVCNFSM6AAAAABO5P3HGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBYGQ3TANBRG4 . You are receiving this because you commented.Message ID: @.***>
Thatβs a good point. And with the right api we could include crypto
Maybe Chris is using Slacker for forex trades and needs real time data.
related to #293
https://exchangeratesapi.io/
should it happen automatically like the C to F parser? π€·ββοΈ