ServiceNowDevProgram / SlackerBot

The official application repository for the bot @Slacker on the sndevs.com workspace.
https://github.com/ServiceNowDevProgram/Hacktoberfest
15 stars 125 forks source link

create a euro to USD parser #276

Open chelming opened 1 year ago

chelming commented 1 year ago

https://exchangeratesapi.io/

should it happen automatically like the C to F parser? πŸ€·β€β™€οΈ

Narasimha677 commented 2 months ago

if we integrate that api we have only 250 limit per month right?

wiz0floyd commented 2 months ago

Yes, though I would be shocked if we run into that limit.

I don't think it should happen every time. I suggest trigger with a πŸ’Ά or πŸ’΅ reaction.

wiz0floyd commented 2 months ago

https://emojipedia.org/euro-banknote https://emojipedia.org/dollar-banknote

earlduque commented 2 months ago

just make sure to have a failure path so the bot can explain why it didn't run

eriemer1 commented 2 months ago

Why not just leverage the oob currency conversion? if you add a record to fx_currency_instance with the amount and currency and set the reference currency to the one you want to convert to it will automatically fill in the reference amount with the converted value.

There are only 5 currencies active oob, but we could turn on the full list and the exchange rates update nightly.

wiz0floyd commented 2 months ago

Maybe Chris is using Slacker for forex trades and needs real time data.

On Wed, Oct 2, 2024, 01:31 eriemer1 @.***> wrote:

Why not just leverage the oob currency conversion? if you add a record to fx_currency_instance with the amount and currency and set the reference currency to the one you want to convert to it will automatically fill in the reference amount with the converted value.

There are only 5 currencies active oob, but we could turn on the full list and the exchange rates update nightly.

β€” Reply to this email directly, view it on GitHub https://github.com/ServiceNowDevProgram/SlackerBot/issues/276#issuecomment-2387662574, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBGRXJYLTDKOFQE6OLADRDZZOAKNAVCNFSM6AAAAABO5P3HGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBXGY3DENJXGQ . You are receiving this because you commented.Message ID: @.***>

Narasimha677 commented 2 months ago

Yes, though I would be shocked if we run into that limit.

I don't think it should happen every time. I suggest trigger with a πŸ’Ά or πŸ’΅ reaction.

did you mean if we ran out free service then we just show the currency emoji?

wiz0floyd commented 2 months ago

No I mean a reaction using the emoji is used to trigger the bot, rather than it being a text based trigger.

On Wed, Oct 2, 2024, 08:02 K Narasimha Reddy @.***> wrote:

Yes, though I would be shocked if we run into that limit.

I don't think it should happen every time. I suggest trigger with a πŸ’Ά or πŸ’΅ reaction.

did you mean if we ran out free service then we just show the currency emoji?

β€” Reply to this email directly, view it on GitHub https://github.com/ServiceNowDevProgram/SlackerBot/issues/276#issuecomment-2388470417, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBGRXMTR6NY42QFORB6AJ3ZZPOG7AVCNFSM6AAAAABO5P3HGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBYGQ3TANBRG4 . You are receiving this because you commented.Message ID: @.***>

eriemer1 commented 2 months ago

That’s a good point. And with the right api we could include crypto

Maybe Chris is using Slacker for forex trades and needs real time data.

chelming commented 1 month ago

related to #293