search

ServiceNowDevProgram / SlackerBot

The official application repository for the bot @Slacker on the sndevs.com workspace.
https://github.com/ServiceNowDevProgram/Hacktoberfest
9 stars 73 forks source link

Added the ice breaker reaction #278

Closed DavidMarcial closed 8 months ago

DavidMarcial commented 8 months ago

Updated the file to add the reaction once the user uses the parser. @earlduque recommended using the Slackbot response instead of the parser that I created. If that is the case I can update this file and remove the code that is storing the ice breaker prompt and just put the response into Slackbot. This pull request should close #277

Lacah commented 8 months ago

I'm a bit confused about this one. Did you create an issue for this yourself just to submit a PR that resolves it, or am I missing something?

DavidMarcial commented 8 months ago

@Lacah Yes I did. So I originally created the ice breaker parser and then after it was submitted thought, "Hey wouldn't it be neat to have it have a reaction as well." Kind of like the so extra reaction. I was not sure how get that extra feature added into the repo besides creating an issue and having a pull request done. Did I go about this the wrong way?

Lacah commented 8 months ago

It's fine, thanks for the background.