search

ServiceStack / Issues

Issue Tracker for the commercial versions of ServiceStack
11 stars 8 forks source link

ServerEventsFeature WriteEventsAsync callback should use cancellation token #774

Closed filipsky closed 2 years ago

filipsky commented 2 years ago

Hi, we have come across the situation that the ServerEventsFeature hangs randomly for long time on faulty network. We tried to use cancellation token to mitigate the problem, but found out that the ServerEventsFeature.WriteEventsAsync callback does not use the callback

I understand we can't prepare the repro, so I will create a PR if you're interested

mythz commented 2 years ago

Thx for the PR! If needed this change is now available from v6.0.3+ that's now available on MyGet