search

ServiceWeaver / weaver-kube

Run Service Weaver applications on vanilla Kubernetes.
Apache License 2.0
61 stars 19 forks source link

kube: prefix `Role` and `RoleBinding` with `serviceweaver` #111

Closed flouthoc closed 3 months ago

flouthoc commented 3 months ago

As of now there are no labels and annotations added to the Roles and RoleBinding created by service-weaver making it difficult for admins to figure out what and why this role was created so add a serviceweaver- prefix.

Naming convention of default of Roles and Rolebindings do have prefix associated to them, for example

NAMESPACE     NAME                                                ROLE                                                  AGE
kube-public   kubeadm:bootstrap-signer-clusterinfo                Role/kubeadm:bootstrap-signer-clusterinfo             17m
kube-public   system:controller:bootstrap-signer                  Role/system:controller:bootstrap-signer               17m
kube-system   kube-proxy                                          Role/kube-proxy                                       17m
kube-system   kubeadm:kubelet-config                              Role/kubeadm:kubelet-config                           17m
kube-system   kubeadm:nodes-kubeadm-config                        Role/kubeadm:nodes-kubeadm-config                     17m
kube-system   system::extension-apiserver-authentication-reader   Role/extension-apiserver-authentication-reader        17m
kube-system   system::leader-locking-kube-controller-manager      Role/system::leader-locking-kube-controller-manager   17m
kube-system   system::leader-locking-kube-scheduler               Role/system::leader-locking-kube-scheduler            17m
kube-system   system:controller:bootstrap-signer                  Role/system:controller:bootstrap-signer               17m
kube-system   system:controller:cloud-provider                    Role/system:controller:cloud-provider                 17m
kube-system   system:controller:token-cleaner                     Role/system:controller:token-cleaner                  17m
flouthoc commented 3 months ago

I can add prefix as systems roles are using serviceweaver:<role> but I have used - as it is being used in other places as well.

flouthoc commented 3 months ago

@rgrandl @mwhittaker PTAL