search

ServiceWeaver / weaver-kube

Run Service Weaver applications on vanilla Kubernetes.
Apache License 2.0
61 stars 19 forks source link

build, push: add support for `podman` #112

Closed flouthoc closed 3 months ago

flouthoc commented 3 months ago

Serviceweaver as of now supports docker as the default build and push tool following PR adds support for podman since podman's CLI is directly compatible with docker and supports both rootless and rootful for build and push.

flouthoc commented 3 months ago

@rgrandl @mwhittaker PTAL

flouthoc commented 3 months ago

This is interesting. Podman provides a similar CLI to docker, so supporting Podman seems pretty straightforward.

Do you know if Podman is widely popular, and what tools people generally use to build and push images? I am worried that once we have a knob for the build tool, people might ask to support many different tools, and they might have completely different CLIs from Docker.

@rgrandl Podman is very popular and it has lot perks as compared to docker. I don't think it is fair to call one better over another. But there are places were podman is better suited than docker. Consider lightweight CI/CD environments where running a daemon is hard and it is undesirable to configure a daemon only for builds I think in such places podman is much better and by default it offers rootless users to build container images with ease. ( cc @rhatdan please feel free to correct me if i missed anything here )

I am worried that once we have a knob for the build tool, people might ask to support many different tools, and they might have completely different CLIs from Docker.

That is a fair concern, Two popular tools which I know are podman and docker and I think if service-weaver sticks to the point that it has no problem in supporting tools which are docker compatible then there should be no issue, right ? And in documentation this can be written that service-weaver supports docker and will accept PR where build tool is compatible with docker CLI ?

flouthoc commented 3 months ago

Personally I am using service-weaver with podman and with this PR i was able to use it without any issues. Since podman is one-to-one compatible with docker I don't think that there is going to be any maintenance overhead in future as well.

rhatdan commented 3 months ago

Thanks this makes sense to me.