search

ServiceWeaver / weaver-kube

Run Service Weaver applications on vanilla Kubernetes.
Apache License 2.0
61 stars 19 forks source link

Removed literal "tag" string from tag. #22

Closed mwhittaker closed 1 year ago

mwhittaker commented 1 year ago

This PR removes a spurious "tag" string from the container image tags. I also removed some stale documentation and fixed some capitalization.

mwhittaker commented 1 year ago

Looks great.

Btw., since docker push can push your image anywhere (e.g., GKE ArtifactsRepository, DockerHub), provided you're logged in etc., we now support image loading from anywhere, is that right? There's a pending issue about this.

Good question. I'm not sure. Reading some docs online, it seems like we have to do some extra work to push to somewhere other than Docker Hub? So I think things won't work right now?

spetrovic77 commented 1 year ago

Looks great. Btw., since docker push can push your image anywhere (e.g., GKE ArtifactsRepository, DockerHub), provided you're logged in etc., we now support image loading from anywhere, is that right? There's a pending issue about this.

Good question. I'm not sure. Reading some docs online, it seems like we have to do some extra work to push to somewhere other than Docker Hub? So I think things won't work right now?

Makes sense. I think I setup Docker to push to GKE artifacts registry using those instructions. :)