search

ServiceWeaver / weaver-kube

Run Service Weaver applications on vanilla Kubernetes.
Apache License 2.0
61 stars 19 forks source link

Can allow custom dockerfile contents #30

Open Lvzhenqian opened 1 year ago

Lvzhenqian commented 1 year ago

As the title says, I need to customize GOPROXY and other environment variables during the build process. To facilitate the download of dependent packages during the go build process..

Due to network reasons, I cannot download dependent packages and directly execute go install and go build..like this:

image
spetrovic77 commented 1 year ago

Hi @Lvzhenqian, thanks for reporting this issue!

The reason we rebuild the weaver-kube binary is that the weaver-kube binary running on your non-Linux machine (I presume, MacOS?) will not run inside the container.

One option would be for us to provide our own set of base container images that include weaver-kube. Would that work for you, network-wise?

Providing other Dockerfile customization options is a more complicated issue and we're not ready to go there unless we really have to.

Lvzhenqian commented 1 year ago

@spetrovic77 Great, my network is difficult to download weaver-kube, using a base container images that includes weaver-kube can solve this problem