search

ServiceWeaver / weaver-kube

Run Service Weaver applications on vanilla Kubernetes.
Apache License 2.0
61 stars 19 forks source link

Remove duplicate imports #47

Closed soroushj closed 1 year ago

soroushj commented 1 year ago

Remove imports that import an already-imported package with a different alias. Also, change the import alias of "k8s.io/api/autoscaling/v2" from v2 to autoscalingv2 for consistency.

mwhittaker commented 1 year ago

Hm, the "deploy" GitHub Action is failing because it doesn't have permissions to upload a container to ghcr.io/serviceweaver/weaver-kube/echo. I think we may have misconfigured the action. Let me look into it.

mwhittaker commented 1 year ago

Just an update, we're sorting out the permissions issue on #51.

spetrovic77 commented 1 year ago

Hi @soroushj , can you rebase and the checks will (hopefully) pass?

soroushj commented 1 year ago

Hi @soroushj , can you rebase and the checks will (hopefully) pass?

Hi @spetrovic77, sure, rebased.