Servicerobotics-Ulm / SmartMDSD-Toolchain

Source code of the SmartMDSD Toolchain, an Eclipse-based IDE for robotics software development and composition
BSD 3-Clause "New" or "Revised" License
8 stars 5 forks source link

Deployment startstop hooks do not work with custom ComponentInstance names #2

Closed alex-lotz closed 5 years ago

alex-lotz commented 5 years ago

Describe the bug When component-instances of the SystemComponentArchitecture model are changed from their ComponentDefinition name to a custom name, then the startstop hooks of these components are not properly deployed and triggered.

To Reproduce Steps to reproduce the behavior:

  1. Create a System with SystemComponentArchitecture model (as well as the TargetPlatform and Deployment models)
  2. Instantiate at least one component in this model
  3. Change the component-instance name to a different value
  4. Deploy and execute the system
  5. Error: the startstop hooks of the component with a custom name are not triggered

Expected behavior Startstop hooks must use the component-instance names instead of the component-definition names.

Screenshots If applicable, add screenshots to help explain your problem.

Toolchain version (and other specific settings) that you are using:

Additional context Add any other context about the problem here.

alex-lotz commented 5 years ago

Fixed by commit https://github.com/Servicerobotics-Ulm/SmartMDSD-Toolchain/commit/632b54a44088b94ae7bda20928982ac606696fb9.