search

Servicerobotics-Ulm / SmartMDSD-Toolchain

Source code of the SmartMDSD Toolchain, an Eclipse-based IDE for robotics software development and composition
BSD 3-Clause "New" or "Revised" License
8 stars 5 forks source link

New component Wizard will not close when using invalid names #9

Open GeorgHeppner opened 4 years ago

GeorgHeppner commented 4 years ago

Describe the bug When creating a new component and choosing a name containing a dot like: "Testcomponent4.0" the wizard does not terminate when clicking finish. The component seems to be created correctly though. View is not changed to modelling view.

To Reproduce Steps to reproduce the behavior:

  1. create new component (tier3)
  2. enter an invalid? name "Testcomponent4.0"
  3. select other properties as desired
  4. klick finish -> Wizard is not finished

Expected behavior The wizard should close, the component be created and the view changed

Screenshots seronet_tescomponent_2

Toolchain version (and other specific settings) that you are using: Seronet Virtual Box Image

Additional context Add any other context about the problem here.

alex-lotz commented 4 years ago

Thanks for the report. Interesting use-case. Dots are not allowed in the Component name as the name is used in various models for cross referencing. But I think there should be an error message instead of not allowing to finish (which is a silent fail-safe behavior).