search

Serviox19 / Sports-App

Node Js / Express / Angular App using MongoDb, Mongoose, and Cheerio to scrape data and store it in a database
0 stars 0 forks source link

Feedback - 18 Assignment #1

Open ntuvera opened 8 years ago

ntuvera commented 8 years ago

Hey @Serviox19, I cloned your repo and took a look at your NBA scraper app...

I ran through your app and the first thing I get was a blank page. I had to look into the code to see if and when anything was happening. From a UX/UI perspective (or anyone who can't see the code), this makes it look like an unfinished site. You can add an $.ajax call on the DOM to hit route just to populate the page.

Your app functions properly storing scraped data, but it's missing the notes/comments functionality. You've got a little over half the puzzle, with the scraping and storing/retrieving data on the back-end. It would be beneficial to use that $.ajax call on the front-end and handle the data return in your /public/index.js Translating this idea of doing dom manipulation with information being passed directly into the client side is similar to what we're doing in Angular... Angular just does it better.

As long as you get the flow of data, you should be abe to build out the rest of the functionality for comments/notes. The only added bit you have to worry about is when you define your schema and create new comments is referencing the id of the article that it belongs to. Also having something appear on the main page, or having a way for the user to know/grab information ;)

Serviox19 commented 8 years ago

Thanks for the feedback Nate! Yeah when I was doing this homework I didnt know why it was coming up blank, and you would manually have to hit that route. Then once you hit the route it would populate the data. So question when you said do an ajax call on the DOM, if im doing it with angular, could I just make a controller for the home page and use an http request to the route that has the scraper?

Serviox19 commented 8 years ago

@ntuvera