search

Servoy / bootstrapextracomponents

MIT License
1 stars 1 forks source link

floatlabel textbox does not compile "type="password"" #46

Closed r4inX closed 1 year ago

r4inX commented 1 year ago

Updates servoy to 2022.12.0.3823 and all compoments to 2022.12. Now trying to create a form with floatlabel-textboxes and as inputType i set "password" (or password-with-eye). Servoy does not compile it to the finished form in browser and ng-desktop.

I remember there was the same bug with non-float textboxes.

-Rain

jcompagner commented 1 year ago

what do you mean it doesn't compile? what do you get? what is the exception? what does the ng build console say?

r4inX commented 1 year ago

the exception is that it does not matter if i say the inputtype is text, email or passwort. In the complied HTML (inspected in the browser inspector) the html property "type="XXX"" is missing for floatlabel-text. In my example of floatlabe-text-password the text is not hidden in the textbox. i added some screenshots.

In Screenshot_4 i marked whats missing, if i add that in the browser-inspector it works.

floatlabel_2 floatlabel_1 floatlabel_how_it_should_be floatlabel_3

r4inX commented 1 year ago

@jcompagner any news about that? our solution is going in production in a few days. As a "workaround" im now using the normal text-fields (not the floatlabel). However i find the floatlabel ones alot better design-wise. Its not a blocker but is still appreciated. Have a nice week.

-rain

jcompagner commented 1 year ago

this is fixed by this commit:

https://github.com/Servoy/bootstrapcomponents/commit/b42cfed9566c40d08be23984cefcde2dbdba0093