search

Servoy / bootstrapextracomponents

MIT License
1 stars 1 forks source link

Progress Bars not rendering in 8.2 #7

Closed seanthomasdevlin closed 7 years ago

seanthomasdevlin commented 7 years ago

I tried to use them in 8.2 pre-release and they didn't render. I also ran the demo solution as-is and same result. Looks like rating might have same result too

pruhsert commented 7 years ago

That's an ugly one. 8.2 upgrades angular and along with that, upgraded angular-ui. Between the version 8.1 used and the new version used in 8.2 there has been a change in the naming of elements

https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes

So formerly the element was < progressbar > and now it needs to be < uib-progressbar >. So what goes wrong here is that basically the directive doesn't pick this up.

Not sure how to deal with that. We might have to ship two versions for a while. Carousel and Rating are also affected, because they are both based on angular-ui.

paronne commented 7 years ago

We need two branches indeed. Bootstrapcomponents and svyExtra already have a svy81x branch and a master branch which is updated to 8.2

pruhsert commented 7 years ago

that should be fixed with the 8.2 release