Sese-Schneider / ha-cover-time-based

Integration which allows cover control based on time.
MIT License
6 stars 7 forks source link

Stop function #2

Open gbeleris opened 9 months ago

gbeleris commented 9 months ago

Many thanks for this. Any chance you could add a stop function? I have a 3rd switch that acts similar to the stop button on the remote. Thanks?

haigaru commented 9 months ago

I also have the same problem: stop button

Sese-Schneider commented 9 months ago

@gbeleris @haigaru I have a few questions before adding this function.

Right now I'm wondering how your implementation is done (please share your configuration). For the open_switch_entity_id and close_switch_entity_id are you using a switch or a button? (I don't think my integration would work with a button, but please correct me if I'm wrong)

What should be implemented? A stop_button_entitiy_id or a stop_switch_entitiy_id? How would a switch to stop the cover even work?

Also, if the entity you're using is indeed a button, couldn't you just create a automation which would toggle the open & close switch off every time the button is pressed?

haigaru commented 9 months ago

I am using the old integration "Cover Time Based RF (script/entity)"

cover configuration

gbeleris commented 9 months ago

I have 3 relays connected to the cover, up, stop, down. They are interlocked, when one turns on the others go off. if there was a stop_switch_entitiy_id I would assign the relay switch I have for the stop function. Hope it's workable. Thanks!

voidspark99 commented 9 months ago

+1; I have RF controlled blinds, with up, down and stop buttons.

fvatter commented 8 months ago

@voidspark99 is it working well for you?

haigaru commented 7 months ago

@gbeleris @haigaru I have a few questions before adding this function.

Right now I'm wondering how your implementation is done (please share your configuration). For the open_switch_entity_id and close_switch_entity_id are you using a switch or a button? (I don't think my integration would work with a button, but please correct me if I'm wrong)

What should be implemented? A stop_button_entitiy_id or a stop_switch_entitiy_id? How would a switch to stop the cover even work?

Also, if the entity you're using is indeed a button, couldn't you just create a automation which would toggle the open & close switch off every time the button is pressed?

It's actually very difficult to express because I'm quite poor at English. I use Google Translate to translate my language back into English.

My problem (and someone else's here)

Conclusion: we really want the author to add a stop option. Because currently, using your integration, I can only open and close the curtain. The option to adjust the tilt of the curtain does not work because it cannot stop the curtain.

Sese-Schneider commented 7 months ago

I've added an optional stop_switch_entity_id for stopping the cover. It supports a switch which will toggle on whenever the cover needs to be stopped.

It is published as a pre-release here: https://github.com/Sese-Schneider/ha-cover-time-based/releases/tag/v2.1.0-beta.1 Select Beta Version when redownloading the repository. Tutorial

BwotbU3quwhyyzPE

@haigaru @gbeleris @voidspark99 @fvatter Please let me know if this solves your problems, then I will publish it as a normal release.

gbeleris commented 7 months ago

thanks for all your efforts with this!

The entity comes up as unavailable after adding the yaml code for it! Any thoughts why this is happening ?

Screenshot 2024-03-14 222031 Screenshot 2024-03-14 222023

Sese-Schneider commented 7 months ago

@gbeleris you've found a bug! The issue was the integration would not load when the tilting entities were not present

Its fixed in the newest pre-release https://github.com/Sese-Schneider/ha-cover-time-based/releases/tag/v2.1.0-beta.2

haigaru commented 7 months ago

I've added an optional stop_switch_entity_id for stopping the cover. It supports a switch which will toggle on whenever the cover needs to be stopped.

It is published as a pre-release here: https://github.com/Sese-Schneider/ha-cover-time-based/releases/tag/v2.1.0-beta.1 Select Beta Version when redownloading the repository. Tutorial

BwotbU3quwhyyzPE BwotbU3quwhyyzPE

@haigaru @gbeleris @voidspark99 @fvatter Please let me know if this solves your problems, then I will publish it as a normal release.

Thank you very much, it works perfectly. But there are some small problems as follows:

Currently the tilting down and tilting up adjustment toolbar can only adjust states 2 and 3.

In my opinion, you should add the tilting down and tilting up bar: 0% is state 2, 50% is state 3, 100% is state 1

Screenshot 2024-03-17 at 22 08 10

Once again I thank you very much (I'm sorry for the way I use English)