search

Sesu8642 / FeudalTactics

Strategy game with countless unique and challenging levels.
GNU General Public License v3.0
79 stars 20 forks source link

Add adaptive icon #54

Closed mueller-ma closed 1 year ago

mueller-ma commented 1 year ago

Closes #53

mueller-ma commented 1 year ago

The icon now has a white background. On my Android device the launcher added such a background to the current icon, so I didn't even notice it's not adaptive.

Edit: I wasn't able to build the app in Android Studio, but there the icon looks good, and I didn't get any syntax issue there.

Sesu8642 commented 1 year ago

Thanks! Could you add yourself to the CLA, please?

As far as I'm concerned, it's sufficient to add your GitHub username. Real name is not required.

Sesu8642 commented 1 year ago

Tested on Android 13 (emulator) with theming and it looks very nice. Good job! image

Sesu8642 commented 1 year ago

I have a couple of questions, mostly for my understanding:

  1. You moved the icons from drawable to mipmap because that's the correct place for icons and has basically been wrong before, right?
  2. ic_launcher-playstore.png seems to be unused and is meant to be uploaded to the Play Store. Since I use /metadata/en-US/images/icon.png for that, could ic_launcher-playstore.png be removed?
  3. What is the reason for the png files to have the round border/shadow baked in? To have the icon be consistent on new and older Android versions? In my emulated Android 7, most pre-installed apps don't have a background like this and Feudal Tactics looks a little out of place. Another disadvantage is that I would need to re-do the pngs if I ever decide to use a different backgound color which I might actually do at some point. I would at least like to have some gimp project file or something to be able to change it easily.
mueller-ma commented 1 year ago
  1. Right, mipmap is the correct folder.
  2. I pushed a commit to remove this file.
  3. I created all icons with the Android Studio icon creator. It's not possible to create icons without a background there.

On Android 7 apps should provide a round icon (https://devblogs.microsoft.com/xamarin/round-launcher-icons-in-android-7-1/) so the background is required for this version. I could restore the old icons for Android 6 and lower. IMO the background looks good, though.

Sesu8642 commented 1 year ago

Android 7.0 is the lowest supported anyway. Thanks!