Sesu8642 / FeudalTactics

Strategy game with countless unique and challenging levels.
GNU General Public License v3.0
79 stars 20 forks source link

Added button to copy seed #68

Closed Mina928 closed 2 months ago

Mina928 commented 1 year ago

This PR works on implementing one of the features in issue #62

This issue suggests methods to save and copy seeds, to make it easier for player to replay the same version of the game again. This PR added a new button next to the random seed button, which upon being clicked saves the seed to the user's clipboard, allowing them to easily paste it somewhere else for future use.

The new button needed different sprites, so two new sprites were created, then packaged using the GDX Texture Packer. The newly packages files replaced the old ones. Currently the random seed button and copy seed button have the same sprites, as trying to get unique sprites was leading to issues.

Sesu8642 commented 1 year ago

I managed to fix the buttons having the same image and iterated on the icons a bit. I think it now works as you intended. :smiley:

There are two changes I would like to have before merging. Let me know whether you want to work more on that or I should do it.

  1. User feedback. Displaying the tick is a good idea but on touch devices it cannot really be seen cause the finger is on the button. I think the pressed button should have a "pressed" version of the copy icon. One idea to give better feedback would be to change the icon to the tick icon for maybe one second after the button was released and then change it back to the copy icon. This would give users a better chance to see the tick. But it's also a bit annoying to implement. Maybe you have better ideas.
  2. The width of the other inputs above the seed row should be increased to match the new seed row width.
Mina928 commented 1 year ago

Wow nice thanks for the help. Yes these are good suggestions, I can start looking into making those changes.

Mina928 commented 1 year ago

Hey so sorry for the lack responsiveness recently. I have gotten very busy and am not sure when I will have time to work on this again. Thanks so much for the experience and assistance, it was fun. Wish you luck!

Sesu8642 commented 1 year ago

No worries. I will finish this. Thanks for your help! :)

Sesu8642 commented 2 months ago

Thanks!