search

SetProtocol / set-protocol-v2

Set Protocol V2
117 stars 94 forks source link

Warnings for non-existent property 'INVALID_ALT_NUMBER' #137

Open rootulp opened 2 years ago

rootulp commented 2 years ago

I observed the following warnings when running yarn install:

(node:7265) Warning: Accessing non-existent property 'INVALID_ALT_NUMBER' of module exports inside circular dependency
(node:7265) Warning: Accessing non-existent property 'INVALID_ALT_NUMBER' of module exports inside circular dependency
rootulp commented 2 years ago

This seems caused by https://github.com/antlr/antlr4/issues/2834 which gets pulled in by solhint

rootulp commented 2 years ago

The latest release of solhint (3.3.6) depends on antlr 4.7.1 (see here) which still contains this issue so upgrading won't resolve. We need antlr 4.9

rootulp commented 2 years ago

We can track https://github.com/protofire/solhint/issues/309 and upgrade solhint after that is resolved